Update project to use Gradle 8.7 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They are some stale(invalid) checks. I'll raise a PR to remove them. |
|
Removed in #137 |
Which tests? |
|
jdneo
approved these changes
Apr 6, 2024
|
Thank you @Arthurm1 for your contribution! |
jdneo
added
the
engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Gradle from 8.1 to 8.7 so jdk 21 can be used to develop
I've left the buildship version as is so some tests will fail unless JDK 17 or lower is used to run them. Can this also be changed or is it set to 7.4.2 for a reason...
build-server-for-gradle/server/src/main/java/com/microsoft/java/bs/core/internal/gradle/Utils.java
Line 45 in ec53a53