fix: Populate test tag correctly for all sourcesets #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthurm1
force-pushed
the
test_tag
branch
2 times, most recently
from
4c0d214 to
104643a
Compare
|
rebased |
jdneo
reviewed
Dec 6, 2023
|
Rebased |
jdneo
approved these changes
Dec 7, 2023
jdneo
changed the title
|
Thank you @Arthurm1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the BSP
BuildTargetTagtag is populated asTestonly when the source set name istest.All other build targets won't have this tag, which means other test configurations (e.g. integration tests) won't have the tag.
Now the code checks to see if there is a
Testtask associated with the source set and populates the tag from that information.