Skip to content

Adding pem certificate support for dotnet 6 or higher #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

embetten
Copy link
Contributor

Adding support for .pem certificates to address artifacts-keyring issue. Note this is only targeting .net 6 or greater versions of the cred provider, since the CreateFromPemFile is only available in .net 5 or greater. Otherwise, we have to implement reading the pem ourselves.

Additional Considerations:

  • Add certificate passwords for pfx files.

@embetten embetten marked this pull request as ready for review September 19, 2024 19:34
@embetten embetten merged commit d6adc53 into master Sep 19, 2024
2 checks passed
@embetten embetten deleted the users/embetten/support-pem-certs branch September 19, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants