Use System.Text.Json for json (de)serialization #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embetten
approved these changes
Apr 19, 2023
johnterickson
approved these changes
Apr 20, 2023
|
/azp where |
|
Azure DevOps orgs getting events for this repository: |
embetten
added a commit
that referenced
this pull request
Mar 6, 2024
- Reverting system.text.json #393 PR due to #484. - Adding warning message for single quotes in endpoint message. - Did not change swix/swr dependencies. --------- Co-authored-by: Jonathan Myers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization and deserialization cost for Newtonsoft.Json causes significant slowdowns, especially in the cases of cached tokens where the process is not long lived. Swapping in System.Text.Json improves startup times.
BenchmarkDotNet=v0.13.5, OS=Windows 11 (10.0.23430.1000)
Intel Xeon CPU E5-1650 v3 3.50GHz, 1 CPU, 12 logical and 6 physical cores
.NET SDK=8.0.100-preview.2.23157.25
[Host] : .NET 6.0.16 (6.0.1623.17311), X64 RyuJIT AVX2
Job-KGDGIP : .NET 6.0.16 (6.0.1623.17311), X64 RyuJIT AVX2
System.Text.Json:
IterationCount=1 RunStrategy=ColdStart WarmupCount=0
IterationCount=3 RunStrategy=ColdStart WarmupCount=0
Newtonsoft.Json:
IterationCount=1 RunStrategy=ColdStart WarmupCount=0
IterationCount=3 RunStrategy=ColdStart WarmupCount=0