🤖 User test baselines have changed for refs/heads/master #36382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20200004-refs/heads/master
branch
from
8332bae to
d0ac227
Compare
sandersn
reviewed
Jan 23, 2020
sandersn
approved these changes
Jan 23, 2020
| @@ -0,0 +1,7 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/sift/index.d.ts(80,15): error TS2307: Cannot find module './core'. | |||
There was a problem hiding this comment.
oh, they fixed a typo and commented out the entire index.d.ts. I'll see if I can get a PR together to fix it.
There was a problem hiding this comment.
🤦♂ "fix typo" secretly deletes feature
There was a problem hiding this comment.
"fix typo" is my new catch-all commit message.
|
I'm going to merge this while sift sorts out its packaging. |
|
crcn/sift.js#174 should fix sift when it ships |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript