-
Notifications
You must be signed in to change notification settings - Fork 12.8k
LanguageService: add getSupportedCodeFixes to make it proxyable #29010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#28106 has example of how to add test that configures plugin and adds proxy
@sheetalkamat I changed Deprecating this API would also resolve #28990, microsoft/vscode#64848 and microsoft/vscode#64872 Regarding tests: as far as I understand, fourslash only tests |
@ajafff for test you can look at #28385 to see how to test this through session. Edit: |
Closing this since #29051 makes more sense than this change |
Fixes: #28966
I'd highly appreciate some pointers on how to test this change. (@sheetalkamat?)
Is the change to the protocol what @DanielRosenwasser meant in #28966 (comment)?