Export default child items not included in 'navtree'

[mjbvz]

From microsoft/vscode#94630

TypeScript Version: 3.9.0-dev.20200409

Search Terms:

• tsserver
• navtree

Code

export default {
    foo: 1,
  };
  export const hello = {
    world: 2,
  }; 

Bug:
The nav tree does not include an entry for foo in it:

[Trace  - 23:25:07.33] <syntax> Response received: navtree (6). Request took 4 ms. Success: true 
Result: {
    "text": "\"test\"",
    "kind": "module",
    "kindModifiers": "",
    "spans": [
        {
            "start": {
                "line": 1,
                "offset": 1
            },
            "end": {
                "line": 6,
                "offset": 6
            }
        }
    ],
    "childItems": [
        {
            "text": "default",
            "kind": "const",
            "kindModifiers": "export",
            "spans": [
                {
                    "start": {
                        "line": 1,
                        "offset": 1
                    },
                    "end": {
                        "line": 3,
                        "offset": 5
                    }
                }
            ]
        },
        {
            "text": "hello",
            "kind": "const",
            "kindModifiers": "export",
            "spans": [
                {
                    "start": {
                        "line": 4,
                        "offset": 16
                    },
                    "end": {
                        "line": 6,
                        "offset": 4
                    }
                }
            ],
            "nameSpan": {
                "start": {
                    "line": 4,
                    "offset": 16
                },
                "end": {
                    "line": 4,
                    "offset": 21
                }
            },
            "childItems": [
                {
                    "text": "world",
                    "kind": "property",
                    "kindModifiers": "",
                    "spans": [
                        {
                            "start": {
                                "line": 5,
                                "offset": 5
                            },
                            "end": {
                                "line": 5,
                                "offset": 13
                            }
                        }
                    ],
                    "nameSpan": {
                        "start": {
                            "line": 5,
                            "offset": 5
                        },
                        "end": {
                            "line": 5,
                            "offset": 10
                        }
                    }
                }
            ]
        }
    ]
}

[kliput]

Is this fix applied in VSCode May release? The bug from microsoft/vscode#94630 still occurs in VSCode 1.46:

Eg. no qosManager symbol that is inside export default, only default is visible.

[subn3t]

@kliput I feel like this broke with the May release. It's taken me a couple of hours to track down this string of bugs, but this is definitely not working the way it was a couple of weeks ago for me.

This is how it worked before:

This is the current behavior:

You have to downgrade to 1.42 before this works again

[kliput]

@subn3t

You have to downgrade to 1.42 before this works again

Is there an issue to fix this in next release or should I create new?

[subn3t]

By all means create a new one, I'm not a GitHub regular so I'm sure I'd screw something up.

…

On Tue, Jun 16, 2020 at 6:40 AM Jakub Liput ***@***.***> wrote: You have to downgrade to 1.42 before this works again Is there an issue to fix this in next release or should I create new? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#37877 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHITPZDXFRFWWXE4MPTGELRW5R2NANCNFSM4MFDA6TQ> .