Skip to content

[docs] fix link to "Parallel Algorithm for Decision Tree" paper #6933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025

Conversation

PriyadarshiAkshay
Copy link
Contributor

The current hyperlink for Meng et al. 2016 redirects to a different proceeding at NeurIPS. Updated the link.

Current hyperlink for Meng et al. 2016 points to an incorrect proceeding at NeurIPS
@jameslamb jameslamb changed the title Update README.md [docs] fix link to "Parallel Algorithm for Decision Tree" paper Jun 2, 2025
@StrikerRUS StrikerRUS added the doc label Jun 3, 2025
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@StrikerRUS
Copy link
Collaborator

/AzurePipelines run

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There was one more place using that same link, which I found like this:

git grep -i 'Communication-Efficient'

I've pushed a commit updating that.

Also... in the future, when you contribute to open source projects on GitHub, don't use the master / main branch of your fork. Create a new branch with your changes. As soon as this is merged, or it any other PRs are merged, master in this repo will have a different history than master on your fork, which will make future contributions difficult.

AFTER this PR is merged, you should delete and recreate your fork, to fix its master branch (if you plan to come back and contribute again... which we hope you do!).

For more information on this, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

@StrikerRUS
Copy link
Collaborator

/AzurePipelines run

@PriyadarshiAkshay
Copy link
Contributor Author

@microsoft-github-policy-service agree
@jameslamb thank you so much!

@StrikerRUS StrikerRUS merged commit 618cfaf into microsoft:master Jun 16, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants