Fix hardcoded paths in CCF install #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
approved these changes
Mar 13, 2020
|
fix_hardcoded_install@6015 aka 20200313.13 vs master ewma over 30 builds from 5691 to 6010 |
|
It looks like the webhook for the |
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #948
This fixes two issues:
$<BUILD_INTERFACE:${EVERCRYPT_INC}>was used without " " for theccf.enclaveandccf.hosttargets, which means that the CCF source directory got exported as an installed include directory.${CMAKE_INSTALL_PREFIX}was hardcoded in theINSTALL_INTERFACE, which means that it was only possible to install CCF in one given location (/tmp/install-ccf, as per the CI Release build).I will create v0.8.2 when this is merged.