-
Notifications
You must be signed in to change notification settings - Fork 225
Members key share retrieval, decryption and submission #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jumaffre
merged 27 commits into
microsoft:master
from
jumaffre:retrieve_encrypted_share
Mar 11, 2020
Merged
Members key share retrieval, decryption and submission #932
jumaffre
merged 27 commits into
microsoft:master
from
jumaffre:retrieve_encrypted_share
Mar 11, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
commented
Mar 9, 2020
jumaffre
commented
Mar 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 68.96% 68.54% -0.42%
==========================================
Files 100 101 +1
Lines 7802 7939 +137
==========================================
+ Hits 5380 5441 +61
- Misses 2422 2498 +76
|
retrieve_encrypted_share@5875 aka 20200310.25 vs master ewma over 30 builds from 5516 to 5855 |
achamayou
reviewed
Mar 9, 2020
achamayou
reviewed
Mar 9, 2020
achamayou
reviewed
Mar 9, 2020
achamayou
reviewed
Mar 9, 2020
achamayou
approved these changes
Mar 9, 2020
olgavrou
approved these changes
Mar 10, 2020
achamayou
reviewed
Mar 10, 2020
I'll merge this PR now as all the comments have been addressed. The key shares feature is very much work in progress and I expect that most of the code written so far will be reworked, or at least refactored. |
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 5. and most of 6. and 6'. in #51
This PR adds two new member RPC
getEncryptedRecoveryShare
andsubmitRecoveryShare
for members to easily retrieve their encrypted shares and submit the then-decrypted share.To achieve this,
cchost
now outputs the network public encryption key on startup for members to easily decrypt their shares (using cryptobox). This was slightly painful sincembedtls
does not yet support x25519 keys and we have to construct the PEM public key manually (see25519.h
).For now, decrypted shares are stored in the node's memory on
submitRecoveryShare
and once the number of submit shares matches the threshold (for now, the number of active members), CCF combines the shares, reconstructk_z
and decrypt the ledger secrets inccf.shares
.There is a new variant of the
recovery_test
e2e test to test the retrieval, decryption (usingpynacl
) and submission of shares.Next: