Add sample handler with basic signature #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 68.9% 69.01% +0.11%
==========================================
Files 100 100
Lines 7824 7819 -5
==========================================
+ Hits 5391 5396 +5
+ Misses 2433 2423 -10
|
|
cert_access_handler@5522 aka 20200303.4 vs master ewma over 20 builds from 5233 to 5520 |
jumaffre
reviewed
Mar 2, 2020
jumaffre
reviewed
Mar 2, 2020
jumaffre
approved these changes
Mar 2, 2020
achamayou
reviewed
Mar 2, 2020
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new handler to the C++ logging app that uses the basic signature (
RequestArgs&), to demonstrate working with the caller's cert.