Add support for validating Genoa attestations #7051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjen1-msft
commented
Jun 12, 2025
|
One possible point of contention is that we currently support attestation version 2. However since we can't get the model of the CPU from these attestations this PR just assumes that they are running on milan. |
achamayou
reviewed
Jun 12, 2025
achamayou
reviewed
Jun 12, 2025
achamayou
reviewed
Jun 12, 2025
achamayou
reviewed
Jun 12, 2025
Is there any mention of this in the spec? Can you update the title and description of the PR to say Genoa, since we aren't adding support for Turin in this PR? Have you been able to manually test this on Genoa? It would be great to set up a Genoa ACI pool as well. |
cjen1-msft
changed the title
achamayou
approved these changes
Jun 13, 2025
achamayou
reviewed
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal PR to add the relevant root public keys for Genoa and Turin.
(Turin is currently disabled until we can validate it)
This means that we can validate the signatures on attestations from Genoa servers.