Skip to content

Remove UVM endorsement descriptor hardcoding at Start and Recovery #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Feb 28, 2025

I think this is all the change we need, because the UVM endorsement descriptor is already passed to /create and /create writes the descriptor to the ledger/KV.

  • Add a test checking that the descriptor is in the initial Tx for both Start and Recover
  • CHANGELOG entry

@achamayou achamayou marked this pull request as ready for review March 4, 2025 11:24
@achamayou achamayou requested a review from a team as a code owner March 4, 2025 11:24
Copy link
Contributor

@cjen1-msft cjen1-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To double check this PR moves the check of UVM endorsements from the startup path to the open decision by the consortium members.

So what root of trust is added to the kv, is this part of the open decision?

@achamayou
Copy link
Member Author

@cjen1-msft yes, that's exactly right. The did/feed/svn of the UVM endorsements validated at startup is captured in public:ccf.gov.nodes.snp.uvm_endorsements in the KV, where it can be audited before open, and forms the initial value of the set that is used to validate new joiners going forward.

The recovery initial tx gets to set this again, on the basis of endorsements found on recovery node startup.

@achamayou achamayou added this pull request to the merge queue Mar 4, 2025
Merged via the queue into microsoft:main with commit 0a3ba2b Mar 4, 2025
21 checks passed
@achamayou achamayou deleted the remove_uvm_endorsement_descriptor_hardcoding_at_start_and_recovery branch March 4, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants