Adding notion of a recovery owner for network recovery #6705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav137
changed the title
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
achamayou
reviewed
Dec 13, 2024
…137/CCF into dev/gsinha/recovery-owner
achamayou
reviewed
Jan 23, 2025
achamayou
reviewed
Jan 23, 2025
achamayou
reviewed
Jan 23, 2025
eddyashton
reviewed
Jan 24, 2025
achamayou
approved these changes
Jan 31, 2025
|
A reminder to update the CHANGELOG before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for a member that can act as a recovery owner and gets assigned the full recovery share to it. Such a member can single handedly recover the network on their own w/o requiring any other recovery members to submit their recovery shares.
This capability is going to be used in the confidential clean room scenario where a confidential recovery service gets created and is able to recover the CCF network on its own using a recovery owner identity. Only if the confidential recovery service is unable to perform recovery then the recovery members can come together and perform break glass recovery by submitting the threshold amount of recovery shares.
Changes done:
Added an optional recovery_role enum in MemberDetails to indicate whether a recovery member is a recovery owner or not.
Added support to set the above flag both via the cchost config file during network create and set_member proposal.
Recovery owners don't count towards the recovery threshold calculation so updated code paths accordingly.
Added test cases to recover a network using the recovery owner.