Remove msgpack from framework - Part II #2449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
remove_msgpack@23340 aka 20210413.2 vs main ewma over 20 builds from 22975 to 23336 Click to see table
|
achamayou
approved these changes
Apr 12, 2021
added 3 commits
April 12, 2021 11:47
eddyashton
reviewed
Apr 12, 2021
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - `kv::Map` is now an alias to `kv::JsonSerialisedMap`, which means all existing applications using `kv::Map` will now require `DECLARE_JSON...` macros (instead of `MSGPACK_DEFINE`) for custom key and value types. Note that this change may affect throughput of existing applications (#2449). |
There was a problem hiding this comment.
I think we should also mention that msgpack is no longer installed or visible in their include paths. So any MSGPACK_DEFINEs in app code, that were previously necessary, actually need to be removed (and replaced with DECLARE_JSON_... if they didn't exist.
Also perhaps a suggestion to restore the lost throughput - "use Blit if you have simple types, or a custom serialiser"?
eddyashton
reviewed
Apr 12, 2021
src/apps/tpcc/app/tpcc_setup.h
Outdated
| @@ -131,7 +131,7 @@ namespace tpcc | |||
| { | |||
| bool is_original = selected_rows.find(i) != selected_rows.end(); | |||
| Stock s = generate_stock(i, wh_id, is_original); | |||
| auto stocks = args.tx.rw(tpcc::TpccTables::stocks); | |||
| auto stocks = args.tx.rw(TpccTables::stocks); | |||
There was a problem hiding this comment.
Nit: I think all of the changes in this file are unnecessary? Or am I missing something?
eddyashton
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2343
kv::Mapis no longer serialised with msgpack by default.TODO:
msgpackdependency folder totest/as we still usemsgpackfor TPCC.