Add set_constitution proposal #2443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
commented
Apr 9, 2021
jumaffre
reviewed
Apr 9, 2021
eddyashton
commented
Apr 9, 2021
jumaffre
approved these changes
Apr 9, 2021
|
set_constitution_proposal@23286 aka 20210412.34 vs main ewma over 20 builds from 22910 to 23274 Click to see table
|
eddyashton
commented
Apr 9, 2021
src/node/proposals.h
Outdated
Comment on lines
57
to
59
| INVALIDATED, //< Proposal was open when its semantics were potentially | ||
| // changed (code or constitution were modified), so it was | ||
| // automatically invalidated |
There was a problem hiding this comment.
I've just realised this is a potentially confusing name, since one of the constitution functions is validate and this is totally unrelated to that concept of validity. Anyone have a better, but still concise, name for "dead because semantics may have changed".
There was a problem hiding this comment.
Obsolete, out-dated, superannuated, antediluvian?
There was a problem hiding this comment.
letmaik
reviewed
Apr 12, 2021
achamayou
approved these changes
Apr 12, 2021
… into set_constitution_proposal
achamayou
pushed a commit
to achamayou/CCF
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal which I thought we already had, but seem to never have implemented. It allows the governance scripts to be updated while the service is live, by a proposal. This is only implemented for JS governance. This is one of the special proposals which invalidates all other proposals since it may change their semantics. I have added this
Invalidatedas a new state because I think its worth distinguishing from other types of closed proposal.