Add JS endpoint for RSA key generation

[wintersteiger]

No description provided.

[ghost]

cwinter_js_gen_rsa@20307 aka 20210311.29 vs main ewma over 20 builds from 19970 to 20289

[achamayou]

LGTM but please consider documenting the growing JS API in Sphinx.

[wintersteiger]

Yes, I agree, we should start documenting this properly. I have trouble seeing where exactly "the JS API" begins and ends and what shape or form the documentation should take. Should there be a general CCF.ts file with docstrings on the functions which we distribute instead of copying it into samples? @letmaik can you take the lead on this, if you're not too busy? I'm happy to write the text for the crypto bits or to set up the infrastructure if you tell me how you'd like to do this.

[wintersteiger]

See also #1765

[letmaik]

Suggested change

	prv_pub_der = prv.public_key().public_bytes(
	Encoding.DER, PublicFormat.SubjectPublicKeyInfo
	)
	pub_der = pub.public_bytes(Encoding.DER, PublicFormat.SubjectPublicKeyInfo)
	return prv_pub_der == pub_der
	return prv.public_key() == pub

[wintersteiger]

That's not right; that comparison is always false because it compares two different key objects (which hold the same key). I initially tried the same and then had to add the complicated conversion to make it work.

[letmaik]

Really? I could have sworn I used that in the past, hmm..
EDIT: works for x509 certs but not for keys...

[letmaik]

Looks good to me, let's tackle the docs in a separate PR.

[wintersteiger]

Yeah, I agree, the docs can go into a separate PR.