Skip to content

Support CA cert bundles #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 1, 2021
Merged

Conversation

letmaik
Copy link
Member

@letmaik letmaik commented Feb 22, 2021

Closes #2221.

@letmaik letmaik requested a review from a team as a code owner February 22, 2021 16:45
@ghost
Copy link

ghost commented Feb 22, 2021

letmaik/ca-cert-bundles@19636 aka 20210301.5 vs main ewma over 20 builds from 19331 to 19632
images

@eddyashton
Copy link
Member

Since a bundle is "just" a concatenation, I wonder if this should be just the plural set_ca_certs rather than set_ca_certs_bundle? If I have a single cert I want to add, it may not be clear to me how I combine/wrap those into a bundle? But if I saw set_ca_certs I'd probably blindly submit my single entry there? And in the reverse case where I already have a bundle (and know its a mere concatenation), I'd still be happy with set_ca_certs? This bike shed has a very nice felt roof.

@letmaik
Copy link
Member Author

letmaik commented Feb 22, 2021

I think semantically there's a big difference and I would rather be more explicit at the possible cost of confusing people so that they have to check the docs.

@achamayou achamayou merged commit 0458b02 into microsoft:main Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow storing CA cert bundles
3 participants