Handle proposals correctly with single member #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
single_member_fixes@7417 aka 20200417.18 vs master ewma over 50 builds from 6987 to 7413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1075.
The problem was the default value of
statein theProposalconstructor - we should read this state from the response, can't assume it isOpen.Then the logic in
vote_using_majorityis mostly sound, except for trying to return the last response, which may not exist. Instead, it now returns theproposal. This changes the return type of a bunch of functions whichreturn vote_using_majority(...), but it looks like nothing was using their return values so this has no impact.