Skip to content

Attempt fix codeql init running #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Attempt fix codeql init running #669

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
786d880
Minor changes missed from last PR
gfs Nov 4, 2022
2de5351
Add explicit codeql init and finalize
gfs Nov 4, 2022
34f6bcf
Attempt 2
gfs Nov 4, 2022
2e1659b
Other pipelines too
gfs Nov 4, 2022
19cd16f
remove dupes per cpnvo
gfs Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/Objects/FileSystemObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ public override string Identity
/// </summary>
public bool? IsExecutable { get; set; }

/// <summary>
/// The type of the executable if it is one
/// </summary>
public EXECUTABLE_TYPE ExecutableType { get; set; } = EXECUTABLE_TYPE.UNKNOWN;

/// <summary>
Expand Down
2 changes: 2 additions & 0 deletions Pipelines/core-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ stages:
- stage: Build
dependsOn: Test
jobs:
- task: CodeQL3000Init@0
- template: templates/dotnet-publish-linux-mac-job.yml
parameters:
projectPath: 'Cli/Cli.csproj'
Expand All @@ -71,6 +72,7 @@ stages:
jobName: 'pack_cli'
projectPath: 'Cli/Cli.csproj'
projectName: '${{ variables.AsaClientName }}'
- task: CodeQL3000Finalize@0

- stage: Release
dependsOn:
Expand Down
14 changes: 2 additions & 12 deletions analyses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,8 @@
"MODIFIED"
],
"ResultType": "FILE",
"Expression": "(is_exe AND windows_exe AND NOT valid_windows_signature) OR (is_exe AND mac_binary AND null_mac_signature)",
"Expression": "(windows_exe AND NOT valid_windows_signature) OR (mac_binary AND null_mac_signature)",
"Clauses": [
{
"Label": "is_exe",
"Field": "IsExecutable",
"Operation": "IsTrue"
},
{
"Label": "windows_exe",
"Field": "ExecutableType",
Expand Down Expand Up @@ -88,13 +83,8 @@
"MODIFIED"
],
"ResultType": "FILEMONITOR",
"Expression": "(is_exe AND windows_exe AND NOT valid_windows_signature) OR (is_exe AND mac_binary AND null_mac_signature)",
"Expression": "(windows_exe AND NOT valid_windows_signature) OR (mac_binary AND null_mac_signature)",
"Clauses": [
{
"Label": "is_exe",
"Field": "FileSystemObject.IsExecutable",
"Operation": "IsTrue"
},
{
"Label": "windows_exe",
"Field": "FileSystemObject.ExecutableType",
Expand Down