-
Notifications
You must be signed in to change notification settings - Fork 287
Update NuGet to point to Azure Artifacts. #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Weird -- I've never seen nbgv fail like this.
|
It seems odd to me that we're only suddenly tripping over this, but I can set the nbgv install task to continue on failure for now. I can't reason out why it's reporting as already installed. I guess we can figure that out later. Update incoming. |
Dotnet includes nbgv now. The correct change is to change the dotnet tool command to be "update". |
I thought it might have something to do with this. Is it necessary to update the tool? Seems like the easiest solution would be to remove the install step entirely. |
Ahh, nice -- didn't know that. I'll push another update. |
@gfs Are you sure about .NET 6 including nbgv? |
It's part of dotnet foundation now: https://github.com/dotnet/Nerdbank.GitVersioning I don't think it comes with the cli you get from dotnet.Microsoft.com but it's a default tool in the pipeline. We still likely want to use update rather than no-op to not have any inconsistencies from the azure pipelines images being behind. |
Maybe I've misunderstood what is occurring and there's something triggering the install from the globals.json or two steps are trying to install it. I thought it was that this was being injected by azure because I've seen it pop up over time in multiple of our repos. |
* Update NuGet to point to Azure Artifacts. * Update docker reference. * Reroute dotnet tool to public NuGet. * Update nbgv-set-version-steps.yml * Change the other nbgv to update too. Co-authored-by: David Alcantar <[email protected]>
* Update NuGet to point to Azure Artifacts. (#658) * Update NuGet to point to Azure Artifacts. * Update docker reference. * Reroute dotnet tool to public NuGet. * Update nbgv-set-version-steps.yml * Change the other nbgv to update too. Co-authored-by: David Alcantar <[email protected]> * Fix Test job Co-authored-by: Michael Scovetta <[email protected]> Co-authored-by: David Alcantar <[email protected]>
This PR removes the dependency on public nuget.org in favor of an authenticated feed via Azure Artifacts. Public users who won't have access to this feed would pull packages from nuget.org, so there shouldn't be any change to anyone's experience.