Skip to content

Gfs/add win7 support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 1, 2019
Merged

Gfs/add win7 support #28

merged 8 commits into from
Apr 1, 2019

Conversation

gfs
Copy link
Contributor

@gfs gfs commented Apr 1, 2019

Adds Windows + 32bit Windows support.
Makefile fixes.
Change to have Gui place NOTICE on build.

gfs added 5 commits March 31, 2019 15:25
Add a new build to the makefile for as broad coverage possible windows support.

Also updates project files to drop the NOTICE file into builds.
@gfs gfs requested a review from scovetta April 1, 2019 00:42
@gfs
Copy link
Contributor Author

gfs commented Apr 1, 2019

Testing this now. Ran into missing on KBs on the image fresh from MSDN.

https://docs.microsoft.com/en-us/dotnet/core/windows-prerequisites?tabs=netcore2x#net-core-supported-windows-versions

@scovetta
Copy link
Member

scovetta commented Apr 1, 2019

Are the NOTICE files identical? Could we just have one of those, and grab it for each build?

@gfs
Copy link
Contributor Author

gfs commented Apr 1, 2019

We could set the cloud build up to place them. That is what I did for the GUI versions - I think you're right I'll update the pipeline + solutions.

@gfs
Copy link
Contributor Author

gfs commented Apr 1, 2019

Fixed using project files.

@gfs
Copy link
Contributor Author

gfs commented Apr 1, 2019

Tested on a Windows 7 VM. Adding a FAQ entry for the KBs you need.

@gfs
Copy link
Contributor Author

gfs commented Apr 1, 2019

Fixed pipeline builds fine now.

@gfs gfs merged commit e1ee0bd into master Apr 1, 2019
@gfs gfs deleted the gfs/add-win7-support branch April 2, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants