Skip to content

wrong file reference on not existing drive #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Stingra-VI opened this issue Jul 31, 2019 · 4 comments
Closed

wrong file reference on not existing drive #251

Stingra-VI opened this issue Jul 31, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Stingra-VI
Copy link

Describe the bug
running a report on a not existing directory shows a wrong drive reference.

I would like to point out that this is my first MS "bug" report. If I forget more details, please get back to me.

To Reproduce
Steps to reproduce the behavior:

  1. run a compare on two existing reports (before / and after), point it to a not existing directory (kinda forgot to create that before)
  2. in the error-message you will see some references to "D:\a\1\s\Cli\Program.CS" (Screenshot Add "Reporting Security Issues" to README. #1) - whereas we do not have that drive conntected or started. (see Screenshot#2)

Expected behavior

  • not that error message. More likely "just the first line, where it states that the path was not found"

Screenshots
2 attached

System Configuration (please complete the following information):

  • OS Version: Windows 10, 1709
  • Application Version: AsaCli-win10-2.0.154
  • CLI or GUI: CLI

Additional Context
after creating that directory the command works as expected

ASA-Burg02
ASA-Bug01

@Stingra-VI Stingra-VI added the bug Something isn't working label Jul 31, 2019
@scovetta
Copy link
Member

Thanks for the report, @Stingra-VI!

For the the D:\a\1\s\Cli\Program.cs location: I'm pretty sure this path is an artifact of the ASA binary being build in Azure DevOps, which uses that directory structure on its hosted build agents.

The exception looks like it's trying to access C:\swrollout\Admin\ASA\… but isn't finding a that directory. Which is strange, since you're in that directory on the command line. I noticed that the case is different (swrollout vs. SwRollout), which might account for it, but we'll take a deeper look!

@gfs
Copy link
Contributor

gfs commented Aug 13, 2019

Thank you for the report @Stingra-VI. I'm able to reproduce this behavior. I'll post a fix by the end of the week that will error out before running the full comparisons if the path doesn't exist.

Is having the path automatically created an important feature for you? It is something I can investigate but is more difficult because ASA runs as Admin/Root and it is obviously undesirable to create an admin owned directory.

@gfs
Copy link
Contributor

gfs commented Aug 13, 2019

Fix pushed. Thanks again for your report @Stingra-VI.

Screen Shot 2019-08-12 at 11 38 10 PM

gfs added a commit that referenced this issue Aug 13, 2019
* Fixes crash when provided non-extant path.

* Update Program.cs
@Stingra-VI
Copy link
Author

Stingra-VI commented Aug 13, 2019 via email

@gfs gfs closed this as completed Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants