Use AADAudience connection string value when present #2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a connection string is provided, and it includes an AADAudience component, use that value to build a scope used when fetching tokens. If no AADAudience is available, default to the commercial value to maintain current behavior in commercial/public cloud.
- Added line to CHANGELOG describing update - Removed audience/scope values from AuthConstants as they are no longer used. Modified tests accordingly.
wired010
changed the title
|
The scopes for Azure Monitor used to have double-slashes in them: |
Move back to a scope of https://monitor.azure...//.default, to generate a token with an audience of https://monitor.azure.../ (includes a trailing slash).
|
Reverted the scope building logic to generate scopes such as https://monitor.azure.com//.default and https://monitor.azure.us//.default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue # .
Changes
When a connection string is provided, and it includes an AADAudience component, use that value to build a scope used when fetching tokens. If no AADAudience is available, default to the commercial value to maintain current behavior in commercial/public cloud.
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors: