Skip to content

Added NetStandard2.0 for Microsoft.ApplicationInsights.NLogTarget #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Dec 29, 2019

Added NetStandard2.0 for Microsoft.ApplicationInsights.NLogTarget to reduce NetCore dependencies.

Fixed dependencies for NetStandard2.0 and removed build warning about System.Net.Http in Microsoft.ApplicationInsights.csproj

Updated NLog to version 4.5.11 to give access to NLog JsonSerializer for better handling of structured logging (future PR when this has been accepted/merged)

  • I ran Unit Tests locally (NetCore-framework only)
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@snakefoot snakefoot changed the title Fixed dependencies for NetStandard2.0 and removed build warning about System.Net.Http Added NetStandard2.0 for Microsoft.ApplicationInsights.NLogTarget Dec 29, 2019
@TimothyMothra
Copy link

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@snakefoot
Copy link
Contributor Author

Fixed merge-conflicts. Please merge when you feel ready

@snakefoot
Copy link
Contributor Author

Fixed merge-conflicts. Please merge when you feel ready

@TimothyMothra
Copy link

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimothyMothra TimothyMothra merged commit e5f73de into microsoft:develop Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants