-
Notifications
You must be signed in to change notification settings - Fork 83
Use Built-in Java HTTP Server instead of Jetty 11 #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
commented
Mar 19, 2025
...-proxy-test/src/main/java/io/micronaut/function/aws/proxy/test/HttpServerEmbeddedServer.java
Outdated
Show resolved
Hide resolved
bd0afdc
to
9aa83fe
Compare
yawkat
reviewed
Mar 24, 2025
...ava/io/micronaut/http/server/tck/lambda/tests/MicronautLambdaHandlerHttpServerTestSuite.java
Outdated
Show resolved
Hide resolved
@yawkat @graemerocher can we merge this? |
No, I want to figure out the octet thing first |
yawkat
approved these changes
Mar 25, 2025
8ae11e8
to
e701c23
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: breaking
Introduces a breaking change
type: improvement
A minor improvement to an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jetty 11 has a CVE. This pull request removes the usage of Jetty 11 and replaces it with the built-in Java HTTP Server support introduced in servlet-core.
Jetty 12 Handler uses
org.eclipse.jetty.server.Request
instead ofjakarta.servlet.http.HttpServletRequest
.org.eclipse.jetty.server.Request
no longer implementsHttpServletRequest
. Because of that, to get rid of Jetty 11, we had two options: rewrite to Jetty 12 or migrateAwsApiProxyTestServer
to use the Java Built-in HTTP Server and remove the usage of Jetty.I gone the path of using the built-in HTTP Server. There are several classes introduced in this PR which I think should be in micronaut core.