Further enhancement to OtlpMetricsSender #6025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
added
enhancement
shakuzen
commented
Mar 14, 2025
There was a problem hiding this comment.
Having this (as package-private) made things more complicated when introducing the Request class that we need to be public, so I removed it. It was only there to demonstrate that the OtlpMetricsSender could be made more generic for use in other registries, but until we verify that need more, let's remove this.
| response = httpRequest.send(); | ||
| } | ||
| catch (Throwable e) { | ||
| throw new Exception(e); |
There was a problem hiding this comment.
Since the HttpSender throws Throwable, we need to catch it here. Wrapping in Exception feels weird but I'm not sure what's better to do.
...ns/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMetricsSender.java
Outdated
Show resolved
Hide resolved
This was referenced Mar 14, 2025
...ns/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMetricsSender.java
Outdated
Show resolved
Hide resolved
...ns/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMetricsSender.java
Show resolved
Hide resolved
...ns/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMetricsSender.java
Outdated
Show resolved
Hide resolved
shakuzen
force-pushed
the
otlpsender-request
branch
2 times, most recently
from
884d7c8 to
df32a06
Compare
...ns/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpMetricsSender.java
Outdated
Show resolved
Hide resolved
shakuzen
force-pushed
the
otlpsender-request
branch
2 times, most recently
from
d7841a0 to
55da842
Compare
shakuzen
force-pushed
the
otlpsender-request
branch
from
55da842 to
4394738
Compare
Introduces an immutable Request object and builder.
shakuzen
force-pushed
the
otlpsender-request
branch
from
4394738 to
7fe776c
Compare
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Johnny Lim <[email protected]>
Merged
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Mar 30, 2025
Signed-off-by: Johnny Lim <[email protected]>
jonatan-ivanov
pushed a commit
that referenced
this pull request
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an immutable Request object and builder for convenience.
See review comments on #5994 and original PR #5691.