Skip to content

Fix loader path #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix loader path #1153

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2018

Closes gh-1151.

@ghost ghost requested a review from mhammond February 3, 2018 04:23
@ghost
Copy link
Author

ghost commented Feb 4, 2018

@mhammond Could you please merge this?

@mhammond
Copy link
Owner

mhammond commented Feb 6, 2018

@mhammond Could you please merge this?

I'll certainly do something like this before the next build - I'm yet to check if a comment works OK in a .pth file (to say exactly why the line exists), and it seems fairly easy to add a different/alternative .pth file only for wheels (to mitigate a small risk the PATH change has a side-effect we haven't considered when the .dll files have also had the post-install treatment).

I'm not likely to make a new build in the next few weeks - is there urgency here? Given the recent pypiwin32 changes, is there anyone actually broken by this at the moment?

@Erotemic
Copy link

is there anyone actually broken by this at the moment?

I'm currently working around it. So, my packages aren't broken per-say, but it would be nice to remove the workaround.

@mhammond mhammond closed this in 1cd8478 Feb 25, 2018
@mhammond
Copy link
Owner

(FTR, I did try using a separate .pth file used only by pip, but that started to get too convoluted, so I just added it to the existing .pth file with comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants