Skip to content

feature: Add nil timezone handling detection to time-date rule #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

feature: Add nil timezone handling detection to time-date rule #1377

merged 1 commit into from
May 26, 2025

Conversation

ccoVeille
Copy link
Contributor

This is the follow-up of something that was raised during another review

We could check if the timezone is not nil (will panic) (almost nobody uses nil for the timezone but ...)
Originally posted by @chavacava in #1370 (comment)

@ccoVeille ccoVeille mentioned this pull request May 25, 2025
Merged
chavacava
chavacava reviewed May 26, 2025
View reviewed changes
chavacava
chavacava reviewed May 26, 2025
View reviewed changes
@ccoVeille ccoVeille requested a review from chavacava May 26, 2025 11:39
@chavacava chavacava merged commit b1c9032 into mgechev:master May 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chavacava chavacava chavacava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccoVeille @chavacava