refactor: removes get from getters names
#1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
May 23, 2025
| // GetPattern - returns the actual pattern | ||
| func (p *LintPattern) GetPattern() string { | ||
| // Pattern - returns the actual pattern | ||
| func (p *LintPattern) Pattern() string { |
There was a problem hiding this comment.
This struct is exported, so you are updating the method name of something that could be used by someone.
And you don't provide a method with deprecated flag.
So I'm doubtful here.
There was a problem hiding this comment.
Thanks for the changes you made
lint/failure.go
Outdated
Comment on lines
84
to
86
| func (f *Failure) GetFilename() string { | ||
| // Filename returns the filename. | ||
| func (f *Failure) Filename() string { | ||
| return f.Position.Start.Filename | ||
| } |
ccoVeille
reviewed
May 24, 2025
lint/failure.go
Outdated
Comment on lines
83
to
87
| // GetFilename returns the filename. | ||
| // Deprecated: Use Filename. | ||
| func (f *Failure) GetFilename() string { | ||
| return f.Filename() | ||
| } |
There was a problem hiding this comment.
If you want to respect specs, it should be in a separated paragraph.
Suggested change
| // GetFilename returns the filename. | |
| // Deprecated: Use Filename. | |
| func (f *Failure) GetFilename() string { | |
| return f.Filename() | |
| } | |
| // GetFilename returns the filename. | |
| // | |
| // Deprecated: Use Filename. | |
| func (f *Failure) GetFilename() string { | |
| return f.Filename() | |
| } |
Also, you could use godoc link to help navigation
Suggested change
| // GetFilename returns the filename. | |
| // Deprecated: Use Filename. | |
| func (f *Failure) GetFilename() string { | |
| return f.Filename() | |
| } | |
| // GetFilename returns the filename. | |
| // | |
| // Deprecated: Use [Filename]. | |
| func (f *Failure) GetFilename() string { | |
| return f.Filename() | |
| } |
revivelib/pattern.go
Outdated
Comment on lines
14
to
15
| // GetPattern - returns the actual pattern | ||
| // Deprecated: Use Pattern. |
There was a problem hiding this comment.
Suggested change
| // GetPattern - returns the actual pattern | |
| // Deprecated: Use Pattern. | |
| // GetPattern - returns the actual pattern. | |
| // | |
| // Deprecated: Use [Pattern]. |
| // GetPattern - returns the actual pattern | ||
| func (p *LintPattern) GetPattern() string { | ||
| // Pattern - returns the actual pattern | ||
| func (p *LintPattern) Pattern() string { |
There was a problem hiding this comment.
Thanks for the changes you made
alexandear
approved these changes
May 24, 2025
ccoVeille
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the prefix
getfrom getter methods (see Getters)Note: this PR includes modifications in 3 functions from
mainthat are not strictly getters but removing thegetprefix makes them read better.