Skip to content

docs: fix displaying rules table on revive.run #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

alexandear
Copy link
Collaborator

This simple change fixes displaying of the "Available Rules" table on https://revive.run/docs#available-rules

Before

image

After

image

@denisvmedia
Copy link
Collaborator

Should we introduce some md linter? 🤔

@ccoVeille
Copy link
Contributor

ccoVeille commented May 15, 2025

But I thought the revive.run site was no longer maintained 🤔

I remember PR on golangci-lint and revive to update the links and use the GitHub repository and not the website

Was it fixed?

@chavacava
Copy link
Collaborator

I have contributor rights on revive.run repo but I'm a newbie on JS. If someone knows how to make it work again (it seems to be a matter of js version updates) I will merge the PRs.

@alexandear
Copy link
Collaborator Author

But I thought the revive.run site was no longer maintained 🤔

I remember PR on golangci-lint and revive to update the links and use the GitHub repository and not the website

Was it fixed?

I fixed revive.run today. See mgechev/revive.run#60.

@alexandear
Copy link
Collaborator Author

Should we introduce some md linter? 🤔

Created #1350 for this.

@alexandear
Copy link
Collaborator Author

I have contributor rights on revive.run repo but I'm a newbie on JS. If someone knows how to make it work again (it seems to be a matter of js version updates) I will merge the PRs.

Yep, I asked @mgechev about revive.run permissions for all maintainers to revive.

@ccoVeille
Copy link
Contributor

WOW, impressive !

@alexandear alexandear merged commit da3ba31 into mgechev:master May 15, 2025
7 checks passed
@alexandear alexandear deleted the docs/fix-available-rules branch May 15, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants