Skip to content

chore: avoid third-party morphy2k/revive-action in CI #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandear
Copy link
Collaborator

@alexandear alexandear commented May 1, 2025

We can run revive without morphy2k/revive-action and still get errors output in GitHub because actions/setup-go contains problemMatcher.

Below is an example failure from this PR (which I reverted):

image

See also #1328 (comment).

Updates #1332

@alexandear alexandear force-pushed the chore/run-revive-with-make branch from ebcaaff to cd52801 Compare May 1, 2025 10:02
alexandear added 2 commits May 1, 2025 13:05
This reverts commit 68561c5.
@alexandear alexandear marked this pull request as ready for review May 1, 2025 10:12
@alexandear alexandear changed the title chore: avoid third-party morphy2k/revive-action chore: avoid third-party morphy2k/revive-action in CI May 1, 2025
@alexandear alexandear merged commit 48c047b into mgechev:master May 2, 2025
7 checks passed
@alexandear alexandear deleted the chore/run-revive-with-make branch May 2, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants