Skip to content

fix: race condition of Package fields #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Apr 9, 2025

Related to #1306, it improves the situation (no race condition) but does not fix it fully.

$ ./revive-bench.sh
722
723
722
723
723
723
723
722
722
723
revive-bench.sh
#!/bin/bash -e

for a in {1..10}; do
    revive ./... | wc -l
done

@chavacava chavacava merged commit fbd90be into mgechev:master Apr 10, 2025
32 checks passed
@ldez ldez deleted the fix/datarace branch April 10, 2025 10:18
mfederowicz pushed a commit to mfederowicz/revive that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants