refactor: string-format implements ConfigurableRule
#1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
changed the title
string-format implement ConfigurableRulestring-format implements ConfigurableRule
alexandear
force-pushed
the
refactor/string-format-configure
branch
from
7a86942 to
7708dec
Compare
|
I wonder how far we are to remove the second argument from Apply interface |
We can do this refactoring in revive v2. |
mfederowicz
pushed a commit
to mfederowicz/revive
that referenced
this pull request
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors the implementation of the
string-formatrule. This rule has a configuration, so it should implement therule.ConfigurableRuleinterface.Benefits of the refactoring
StringFormatRule.ParseArgumentsTest.