Skip to content

fix: extractInstructionFromJSON returns an error #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

alexandear
Copy link
Collaborator

The PR fixes the function extractInstructionFromJSON used for tests. It should return an error, but just prints an error and returns nil.

@alexandear alexandear force-pushed the fix/return-err-in-test branch from 5851193 to ac74ccc Compare October 28, 2024 09:14
@denisvmedia denisvmedia merged commit 511e4e6 into mgechev:master Oct 29, 2024
4 checks passed
@alexandear alexandear deleted the fix/return-err-in-test branch October 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants