prepareSkips: to resolve regexps in excludes #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfederowicz
force-pushed
the
debug-exclude-regex
branch
from
52c1b0b to
f970547
Compare
|
@chavacava, could you please review this when you have a moment? Thank you! |
denisvmedia
reviewed
Jan 29, 2025
denisvmedia
reviewed
Jan 29, 2025
…g-exclude-regex # Conflicts: # revivelib/core.go
mfederowicz
force-pushed
the
debug-exclude-regex
branch
from
2ea5080 to
c9f562f
Compare
denisvmedia
reviewed
Feb 4, 2025
alexandear
reviewed
Feb 4, 2025
Closed
chavacava
added a commit
that referenced
this pull request
Feb 13, 2025
chavacava
added a commit
that referenced
this pull request
Feb 13, 2025
* fix: exclusions are no longer working as before (fixed by reverting #1060) * removes failing test on main.GetVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1011
I know that we use https://github.com/mgechev/dots to process includePatterns and excludePatterns but I think there is better solution for that (https://github.com/bmatcuk/doublestar)
func Glob(fsys fs.FS, pattern string, opts ...GlobOption) ([]string, error)- return matching paths wehre pattern can be regexp or normal file pathmy PR uses that function and converts regexp pattern to list of paths which next can be used to process packages in
dots.ResolvePackages(of course if we set more then one includepath it will be processed individualy)example:
./revive -exclude '**/linux*' -formatter friendly ./... vendor/...