Skip to content

time-naming missing cases #571

Closed
@butuzov

Description

@butuzov

Describe the bug
time-naming check missing cases.

  • Hours (all other hour related case)
  • Min (as in RULES_DESCRIPTIONS.md) (all other minute related case)
  • Singular Forms

To Reproduce

Hour     = time.Hour      // MATCH /var Hour is of type time.Duration; don't use unit-specific suffix "Hour"/
oneHour  = time.Hour      // MATCH /var oneHour is of type time.Duration; don't use unit-specific suffix "Hour"/
twoHours = 2 * time.Hour  // MATCH /var twoHours is of type time.Duration; don't use unit-specific suffix "Hours"/
TenHours = 10 * time.Hour // MATCH /var TenHours is of type time.Duration; don't use unit-specific suffix "Hours"/
SixHours = 6 * time.Hour  // MATCH /var SixHours is of type time.Duration; don't use unit-specific suffix "Hours"/

oneMin     = time.Minute     // MATCH /var oneMin is of type time.Duration; don't use unit-specific suffix "Min"/
Min        = time.Minute     // MATCH /var Min is of type time.Duration; don't use unit-specific suffix "Min"/
twoMin     = 2 * time.Minute // MATCH /var twoMin is of type time.Duration; don't use unit-specific suffix "Min"/
SixMin     = 6 * time.Minute // MATCH /var SixMin is of type time.Duration; don't use unit-specific suffix "Min"/
SixMins    = 6 * time.Minute // MATCH /var SixMins is of type time.Duration; don't use unit-specific suffix "Mins"/
SixMinutes = 6 * time.Minute // MATCH /var SixMinutes is of type time.Duration; don't use unit-specific suffix "Minutes"/

Expected behavior

to match duration variables

Additional context
Found on testing revive integration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions