Skip to content

Add support for constructing Buffer from std::array #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2018
Merged

Add support for constructing Buffer from std::array #138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
757d2b6
Add support for constructing Buffer from std::array
Nov 17, 2018
b48036f
use std::array functions for pointer and size of data
Nov 19, 2018
248d1b0
Delete construction of buffer with rvalue arrays
Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions include/cppkafka/buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,17 @@ class CPPKAFKA_API Buffer {
static_assert(sizeof(T) == sizeof(DataType), "sizeof(T) != sizeof(DataType)");
}

/**
* Constructs a buffer from an array
*
* \param data The the array to be used as input
*/
template <typename T, size_t N>
Buffer(const std::array<T, N>& data)
: data_(reinterpret_cast<const DataType*>(&data[0])), size_(N * sizeof(T)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: can you use data.data() and data.size() rather than &data[0] and N * sizeof(T) here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do! first time working with std::arrays

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, that works! One more thing: can you add a deleted constructor taking a std::array<T, N>&& just like there is for vector and string? e.g. this one. This will make sure people can't misuse Buffer and construct it from a temporary array, which will end up making the buffer contain garbage once it goes out of scope.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed

static_assert(sizeof(T) == sizeof(DataType), "sizeof(T) != sizeof(DataType)");
}

// Don't allow construction from temporary vectors
template <typename T>
Buffer(std::vector<T>&& data) = delete;
Expand Down