-
-
Notifications
You must be signed in to change notification settings - Fork 95
stdlib zoneinfo support #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Now that Django 4.0 is out I think there might be addition pressure to port away from This might help: https://pytz-deprecation-shim.readthedocs.io/en/latest/index.html |
Thanks for bringing this up @nikolaik. I will probably try to follow your second option more than the other two. Here's the general release schedule I've got in my head:
Hopefully there's good compatibility between the strings used by zoninfo and pytz. If not perhaps this project can provide some scripts or examples to help users migrate their databases. |
For our use we ended up adding a vendored version of |
Why would you drop support for old Django versions? What about Django 2.2+ would prevent someone from using zoneinfo? |
good point @rawbeans , if there's no API changes it should be fine to continue to support django 2.2 |
To those following this thread: as far as deprecating and eventually dropping support for
Then since django is planning to drop support for Thoughts / feedback welcome |
I just merged #81, and released version 5.0 to pypi which includes zoneinfo support, 90% thanks to @tim-schilling 's work on #80. Please give it a try when you get a chance, and open bug reports for any issues you run across. Thanks & cheers |
Have you considered adding support for https://docs.python.org/3.9/library/zoneinfo.html in some way?
There are tree approaches that come to mind.
use_pytz
as a new parameter onTimeZoneField
, defaulting to False which would start returning ZoneInfo objects from db instead of pytz ones. Deprecating pytz support.use_pytz
parameter defaulting to True. Not deprecating pytz.Thanks for a great package btw, keep up the good work!
The text was updated successfully, but these errors were encountered: