fix: patch proto to latest + update script #953
Conversation
📝 WalkthroughWalkthroughThe pull request introduces updates to the protobuf-related dependencies and generated code across multiple files. The primary changes involve upgrading the protobuf library from version 3.5.1 to 3.7.1, which impacts the Changes
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Build as Build System
participant Protoc as Protobuf Compiler
participant Code as Generated Code
Dev->>Build: Trigger build/generate task
Build->>Protoc: Execute with --rs_out
Protoc-->>Code: Generate Rust protocol buffer files
Code-->>Build: Updated protocol buffer implementations
Build->>Dev: Build complete
The sequence diagram illustrates the updated protobuf code generation process, highlighting the transition to the new Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.ghjk/lock.json (1)
733-767: Dependency entry documentation.This new block for
bciqn2ct4mwrwyise3qlnabpine33dzt3lvnrhrbnkw4pnyryfe5is5alooks correct for protobuf-codegen 3.7.1. Consider documenting why this new entry is introduced, to aid future maintainers in understanding the rationale behind multiple cryptic references in the lock file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.ghjk/lock.json(3 hunks)src/substantial/Cargo.toml(1 hunks)src/substantial/src/protocol/events.rs(2 hunks)src/substantial/src/protocol/metadata.rs(2 hunks)tools/tasks/gen.ts(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- src/substantial/src/protocol/metadata.rs
- src/substantial/src/protocol/events.rs
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: bulid-docker (linux/arm64, custom-arm)
- GitHub Check: bulid-docker (linux/amd64, custom-ubuntu-large)
- GitHub Check: lint-compat (macos-14, aarch64-apple-darwin, false)
- GitHub Check: lint-compat (macos-13, x86_64-apple-darwin, false)
- GitHub Check: test-full
- GitHub Check: pre-commit
🔇 Additional comments (5)
tools/tasks/gen.ts (2)
22-22: Upgrade to protobuf-codegen v3.7.1 confirmed.This aligns with the PR objective to patch the protobuf dependency to the latest version. Ensure all references to the old version (3.5.1) have been removed and that the new library remains compatible with existing code.
31-31: Confirm that--rs_outis supported in your local environment.The switch from
--rust_outto--rs_outis correct for newer protobuf releases, but verify that your local protoc binary and protobuf plugin are up-to-date to avoid compilation errors.Please run the following script to confirm your current protoc version and search for references to
--rust_out:src/substantial/Cargo.toml (1)
13-13: Dependencies updated to the correct version.Upgrading the
protobufcrate to 3.7.1 is consistent with the PR objective. Confirm that all generated Rust files are in sync with this version..ghjk/lock.json (2)
891-891: Updated install references.This change updates the relevant installs array to reference the new crate ref, ensuring it aligns with the upgraded library. Good job keeping references consistent.
3087-3088: Confirm that the crateName references remain consistent.The new port ID
bciqifvrtbr5a6nomogpnbn7jxwscqpepdgh67lrsjpkh6t2odnjrnmacorrectly maps to v3.7.1 forprotobuf-codegen. Double-check if the older or duplicate reference for 3.5.1 is fully removed or replaced elsewhere.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 77.72% 77.72%
=======================================
Files 154 154
Lines 19154 19154
Branches 1930 1930
=======================================
Hits 14888 14888
Misses 4243 4243
Partials 23 23 ☔ View full report in Codecov by Sentry. |
Update protobuf-codegen and protobuff to latest (3.7.1) --- - [ ] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Dependency Updates** - Updated `protobuf` library from version 3.5.1 to 3.7.1 - Updated `protobuf-codegen` crate to version 3.7.1 - **Build Configuration** - Modified protobuf compiler output option from `--rust_out` to `--rs_out` - Simplified protobuf code generation command - **Compatibility** - Ensured compatibility with latest protobuf runtime version <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Update protobuf-codegen and protobuff to latest (3.7.1) --- - [ ] The change comes with new or modified tests - [ ] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change <!-- This is an auto-generated comment: release notes by coderabbit.ai --> - **Dependency Updates** - Updated `protobuf` library from version 3.5.1 to 3.7.1 - Updated `protobuf-codegen` crate to version 3.7.1 - **Build Configuration** - Modified protobuf compiler output option from `--rust_out` to `--rs_out` - Simplified protobuf code generation command - **Compatibility** - Ensured compatibility with latest protobuf runtime version <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Update protobuf-codegen and protobuff to latest (3.7.1)
Migration notes
Summary by CodeRabbit
Release Notes
Dependency Updates
protobuflibrary from version 3.5.1 to 3.7.1protobuf-codegencrate to version 3.7.1Build Configuration
--rust_outto--rs_outCompatibility