Skip to content

fix(release): Fix fat CLI compilation #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 22, 2024
Merged

fix(release): Fix fat CLI compilation #730

merged 18 commits into from
May 22, 2024

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented May 20, 2024

  • Fix fat CLI compilation

  • Bump to 0.4.2

  • Bump wasmtime to 21

  • Bump rust to 1.78.0

  • The change comes with new or modified tests

  • Hard-to-understand functions have explanatory comments

  • End-user documentation is updated to reflect the change

@Natoandro Natoandro requested review from Yohe-Am, zifeo, michael-0acf4 and destifo and removed request for Yohe-Am May 20, 2024 12:50
michael-0acf4
michael-0acf4 previously approved these changes May 20, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.52%. Comparing base (bbdfd35) to head (e157f1f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   74.05%   73.52%   -0.53%     
==========================================
  Files         120      120              
  Lines       13777    14142     +365     
  Branches     1407     1416       +9     
==========================================
+ Hits        10202    10398     +196     
- Misses       3549     3717     +168     
- Partials       26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yohe-Am
Copy link
Contributor

Yohe-Am commented May 22, 2024

So the tests took 30 minutes with each file taking an avg of 30 seconds. Not entirely sure why python_test is taking that long.
image

Copy link
Contributor

@michael-0acf4 michael-0acf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yohe-Am Yohe-Am merged commit 01333b9 into main May 22, 2024
12 checks passed
@Yohe-Am Yohe-Am deleted the fix-release branch May 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants