update package version for release 2.0 #25
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughThe version number in the Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
clients/js/package.json(1 hunks)
🔇 Additional comments (1)
clients/js/package.json (1)
1-79: Verify release artifacts and documentation
This PR introduces a new major release. Please confirm that:
- CHANGELOG.md (or equivalent) has been updated with the v2.0.0 changes.
- README and any user-facing docs reference the new version.
- Your release workflow (tags, GitHub Releases, CI/CD pipelines) is configured to publish v2.0.0 to npm.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Lite
📒 Files selected for processing (1)
clients/js/package.json(1 hunks)
🔇 Additional comments (2)
clients/js/package.json (2)
4-4: Version updated to valid SemVer
The version has been bumped to"2.0.0", which now fully conforms to SemVer (major.minor.patch).
3-3:⚠️ Potential issueRemove duplicate "name" field
Having two"name"keys is invalid and the latter will override the former. Remove the redundant duplicate entry to ensure valid JSON and avoid confusion.Apply this diff:
@@ -2,3 +2,2 @@ "name": "@metaplex-foundation/digital-asset-standard-api", - "name": "@metaplex-foundation/digital-asset-standard-api",Likely an incorrect or invalid review comment.
| "version": "1.1.0-beta.1", | ||
| "name": "@metaplex-foundation/digital-asset-standard-api", | ||
| "version": "2.0.0", | ||
| "description": "Open-source specification for interacting with digital assets on Solana", |
There was a problem hiding this comment.
Deduplicate the "description" field
There are currently two "description" keys. Delete one to prevent key collisions and maintain a clean, valid JSON structure.
Example diff to collapse into a single entry:
@@ -5,3 +5,2 @@
"version": "2.0.0",
- "description": "Open-source specification for interacting with digital assets on Solana",
- "description": "Open-source specification for interacting with digital assets on Solana",
+ "description": "Open-source specification for interacting with digital assets on Solana",Committable suggestion skipped: line range outside the PR's diff.
|
Not needed as already automatically done by CI: 0899e07 |
No description provided.