-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for Bubblegum leaf schema V2 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Summary by CodeRabbit
WalkthroughThe changes update type definitions in a TypeScript file by adding new optional fields to two exported types. Specifically, three optional metadata fields are added to the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AssetCompressionType
participant AssetOwnershipType
Client->>AssetCompressionType: Accesses/uses new optional fields (collection_hash, asset_data_hash, flags)
Client->>AssetOwnershipType: Accesses/uses new optional field (non_transferable)
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
clients/js/src/types.ts
(2 hunks)
🔇 Additional comments (2)
clients/js/src/types.ts (2)
458-470
: V2 schema implementation looks good.The implementation correctly adds optional fields to support Bubblegum leaf schema V2 while maintaining backward compatibility with existing V1 assets. The field types are consistent with the existing pattern.
472-479
: Ownership type extension correctly handles V2 schema.The addition of the optional
non_transferable
field to the ownership type properly handles the V2 schema requirement while preserving backward compatibility.
Notes
Testing
V1 asset
V2 asset (note flags is wrong but that's true with the actual DAS indexing for this asset):