-
Notifications
You must be signed in to change notification settings - Fork 132
Better logging for Kube pod failures #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thedanvail
commented
Jun 13, 2022
- Handles the error more gracefully if we receive from Kube's API when trying to spin up a pod
- Updated CHANGELOG with new changes
Hopefully this is the functionality that was requested from #110 - if not, can still make changes. Thought about using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! See comments inline.
All right, I've switched over to using |
I see some checks failed, I'll look at those in the morning |
LGTM, @meowjesty can you review this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Dan, thanks for the help in improving this! The lack of context kinda tripped me over a few times.
My main suggestion comes in the form that we probably don't need to have a Result
here, as we just crash when this fails anyway. Just change some of the unwrap
s into expect
s (also no need to change every single one).
Edit: Outdated, please ignore this (my bad)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last change and we can merge it :)
- Moved the CHANGELOG line to the `unreleased` section - Added `?` in `pod_api.rs` to potentially return an error
Great, can you merge main into your branch so tests will run before merging? |
Working on fixing the tests |
Tests are passing, the e2e are just a bit flaky at the moment (need to look into it). Merging to main, thanks again @thedanvail ! |