Skip to content

FS-1518: update bmc-toolbox/common #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

FS-1518: update bmc-toolbox/common #211

merged 1 commit into from
Jun 11, 2024

Conversation

DoctorVin
Copy link
Contributor

What does this PR do

Update the version of bmc-toolbox/common to account for SMC x12sth-sys

How can this change be tested by a PR reviewer?

Build alloy at this SHA. Reserve a m3.small.x86.v1 (w/iGPU). Enroll into the sandbox and follow the inventory. The correct output should be:

➜  mctl git:(main) ✗ ./mctl --config ~/.mctl/kind.yaml get server -s abcdf392-1aed-4070-b33c-3394319f4416
[
  {
    "updated": "2024-06-11T19:35:17.898328Z",
    "id": "abcdf392-1aed-4070-b33c-3394319f4416",
    "facility": "sandbox",
    "name": "abcdf392-1aed-4070-b33c-3394319f4416",
    "bmc_address": "10.197.132.37",
    "vendor": "supermicro",
    "model": "x12sth-sys",
    "serial": "E895731X4500534"
  }
]```

Note that the model is tracked as `x12sth-sys` and not the motherboard model of `SYS-510T-MR2-EI018`.

@DoctorVin DoctorVin merged commit 26374d0 into main Jun 11, 2024
9 checks passed
@DoctorVin DoctorVin deleted the vc/update-bmc-toolbox branch June 11, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants