Format device model and keep updated in store #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the server vendor, model, serial attributes are kept updated based on various cases as covered in the added tests
joelrebel
changed the title
DoctorVin
reviewed
Mar 19, 2024
| newModelDefined := newModelNumber != unknown && newModelNumber != "" | ||
| currentModelUndefined := currentModelNumber == unknown || currentModelNumber == "" | ||
|
|
||
| // model number to be updated |
There was a problem hiding this comment.
Why are we even querying things that will never change?
There was a problem hiding this comment.
for the record, the reasons were discussed in another channel, to summarise,
theres a few exceptional cases like - when bmc-toolbox/common does not yet format the model number the model attribute in the store needs to be updated.
DoctorVin
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Ensures the server vendor, model, serial attributes are always formatted and updated as expected in the store.