[FS-539] Implement out of band bios configuration collection #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogomatsubara
changed the title
I'll merge them individually and rebase this branch on main so we can have a neater history. |
Newer version of bmc-toolbox/common package added a NICPorts attribute of type []*common.NICPort to common.NIC
During out of band inventory collection also collects bios configuration if the BMC supports it.
pin bmclib to 6f5089b since 100c294 introduced a bug that causes the context to be cancelled when connecting to the bmc
In case the provider doesn't implement a BiosConfigurationGetter, don't add that as an error in the asset which allows inventory publishing to continue.
diogomatsubara
force-pushed
the
FS-539-dell-oob-bios-config
branch
from
b52fd54 to
e94a887
Compare
|
@joelrebel I merged all the renovate deps into main, rebased this branch on main and it's ready for a stamp. Thanks for the review! |
joelrebel
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
How can this change be tested by a PR reviewer?
Running alloy oob inventory collection against a dell system