Skip to content

feat(ui): add views for Responses #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

feat(ui): add views for Responses #2293

merged 1 commit into from
May 28, 2025

Conversation

ehhuang
Copy link
Contributor

@ehhuang ehhuang commented May 27, 2025 •
edited
Loading

What does this PR do?

  • Add responses list and detail views
  • Refactored components to be shared as much as possible between chat completions and responses

Test Plan

image image

added tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 27, 2025
@ehhuang ehhuang force-pushed the pr2293 branch 9 times, most recently from b948c24 to 11bde4a Compare May 28, 2025 04:20
@ehhuang
responses table, responses details
de53390 
# What does this PR do?


## Test Plan
# What does this PR do?


## Test Plan
@ehhuang ehhuang changed the title responses table, responses details feat(ui): add views for Responses May 28, 2025
@ehhuang ehhuang marked this pull request as ready for review May 28, 2025 04:34
ashwinb
ashwinb approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:stamp-approved:

❤️ 🚀 🔥

@ashwinb ashwinb merged commit 56e5ddb into meta-llama:main May 28, 2025
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@leseb leseb Awaiting requested review from leseb leseb is a code owner

@bbrowning bbrowning Awaiting requested review from bbrowning bbrowning is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehhuang @ashwinb @facebook-github-bot