fix: chat completion with more than one choice #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ehhuang
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
terrytangyuan,
leseb and
bbrowning
as code owners
ehhuang
force-pushed
the
pr2288
branch
2 times, most recently
from
01ccfaa to
5c580c3
Compare
ashwinb
reviewed
May 27, 2025
| @@ -1377,6 +1377,7 @@ async def openai_chat_completion( | |||
| outstanding_responses = [] | |||
| # "n" is the number of completions to generate per prompt | |||
| n = n or 1 | |||
| print(f"n: {n}") | |||
ashwinb
approved these changes
May 27, 2025
ehhuang
force-pushed
the
pr2288
branch
4 times, most recently
from
e2cd42f to
6dc8215
Compare
# What does this PR do? ## Test Plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug in openai_compat where choices are not indexed correctly.
Test Plan
Added a new test.
Rerun the failed inference_store tests:
llama stack run fireworks --image-type conda
pytest -s -v tests/integration/ --stack-config http://localhost:8321 -k 'test_inference_store' --text-model meta-llama/Llama-3.3-70B-Instruct --count 10