chore: use dependency-groups for dev #2287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan and
bbrowning
as code owners
facebook-github-bot
added
the
CLA Signed
leseb
force-pushed
the
use-dependency-groups
branch
3 times, most recently
from
d0e328b to
5135b09
Compare
|
wow, TIL |
leseb
force-pushed
the
use-dependency-groups
branch
from
5135b09 to
fc37ca7
Compare
|
Need #2289 for pre-commit to be happy! |
The previous `[project.optional-dependencies]` was misrepresenting what the packages were. They were NOT optional dependencies to the project but development dependencies. Unlike optional dependencies, development dependencies are local-only and will not be included in the project requirements when published to PyPI or other indexes. As such, development dependencies are not included in the [project] table. Additionally, the dev group is synced by default. Source: https://docs.astral.sh/uv/concepts/projects/dependencies/#development-dependencies Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
use-dependency-groups
branch
from
fc37ca7 to
49f5d33
Compare
ashwinb
approved these changes
May 27, 2025
| @@ -61,6 +61,7 @@ repos: | |||
| "--frozen", | |||
| "--no-hashes", | |||
| "--no-emit-project", | |||
| "--no-default-groups", | |||
There was a problem hiding this comment.
I don't know if this is right, not that I care too much about requirements.txt :)
There was a problem hiding this comment.
+1, this will actually not sync the dev group which is synced by default.
leseb
added a commit
to leseb/llama-stack
that referenced
this pull request
May 28, 2025
Followup of meta-llama#2287. We must use `--group` when running commands with uv. Signed-off-by: Sébastien Han <[email protected]>
ashwinb
pushed a commit
that referenced
this pull request
May 28, 2025
# What does this PR do? Followup of #2287. We must use `--group` when running commands with uv. <!-- Provide a short summary of what this PR does and why. Link to relevant issues if applicable. --> <!-- If resolving an issue, uncomment and update the line below --> <!-- Closes #[issue-number] --> Signed-off-by: Sébastien Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous
[project.optional-dependencies]was misrepresenting what the packages were. They were NOT optional dependencies to the project but development dependencies. Unlike optional dependencies, development dependencies are local-only and will not be included in the project requirements when published to PyPI or other indexes. As such, development dependencies are not included in the [project] table. Additionally, the dev group is synced by default.Source:
https://docs.astral.sh/uv/concepts/projects/dependencies/#development-dependencies